[alsa-devel] [PATCH v2 3/3] ASoC: rt5677: Remove never used variables

Andy Shevchenko andriy.shevchenko at linux.intel.com
Wed Jul 19 13:48:33 CEST 2017


On Wed, 2017-07-19 at 12:24 +0100, Mark Brown wrote:
> On Tue, Jul 18, 2017 at 08:34:19PM +0300, Andy Shevchenko wrote:
> > There are two variables that have never been used.
> > 
> > sound/soc/codecs/rt5677.c:785:35: warning: ‘in_vol_tlv’ defined but
> > not used [-Wunused-const-variable=]
> > static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -3450, 150, 0);
> > 
> > sound/soc/codecs/rt5677.c:783:35: warning: ‘out_vol_tlv’ defined but
> > not used [-Wunused-const-variable=]
> > static const DECLARE_TLV_DB_SCALE(out_vol_tlv, -4650, 150, 0);
> > 
> > Simple remove them.
> 
> Are we sure this doesn't mean something has the wrong TLV or a missing
> TLV?

Good question.

If it so, it should not have been working (properly) at the beginning.

Guys from Realtek, can you comment on this?

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the Alsa-devel mailing list