[alsa-devel] [PATCH 1/1] ALSA: Tascam US-16x08 DSP mixer quirk

Takashi Iwai tiwai at suse.de
Thu Jan 26 11:18:22 CET 2017


On Thu, 26 Jan 2017 09:37:23 +0100,
Detlef Urban wrote:
> 
> Add mixer quirk for Tascam US-16x08 usb interface.
> Even that this an usb compliant device,
> the input channels and DSP functions (EQ/Compressor)
> arn't accessible by default.
> 
> Signed-off by: Detlef Urban <onkel at paraair.de>

Through a quick glance, the patch doesn't seem to follow the standard
coding style.  Please reformat all in a style defined in
Documentation/process/coding-style.rst (or formerly
Documentation/CodingStyle).

Also, you seem using some global variables.  These are broken if you
have multiple devices.  That is, they have to be allocated
dynamically.

Currently we have no private data field assigned to either usb audio
card or mixer object, so we'll need a preliminary patch to add it
beforehand.


thanks,

Takashi


More information about the Alsa-devel mailing list