[alsa-devel] [PATCH 17/53] ALSA: x86: Drop unused hw_silence field

Ughreja, Rakesh A rakesh.a.ughreja at intel.com
Fri Feb 3 05:25:43 CET 2017



>-----Original Message-----
>From: alsa-devel-bounces at alsa-project.org [mailto:alsa-devel-bounces at alsa-
>project.org] On Behalf Of Pierre-Louis Bossart
>Sent: Friday, February 3, 2017 1:57 AM
>To: Takashi Iwai <tiwai at suse.de>
>Cc: alsa-devel at alsa-project.org; Anand, Jerome <jerome.anand at intel.com>
>Subject: Re: [alsa-devel] [PATCH 17/53] ALSA: x86: Drop unused hw_silence
>field
>
>
>
>On 02/02/2017 02:04 PM, Takashi Iwai wrote:
>> On Thu, 02 Feb 2017 20:11:10 +0100,
>> Pierre-Louis Bossart wrote:
>>> On 2/2/17 11:02 AM, Takashi Iwai wrote:
>>>> It's nowhere used.  Let's drop it.
>>> That's one of the things I wanted to add. When you start playback
>>> there is a 1-2s period where the receiver is still looking at the data
>>> to figure out if it's PCM or compressed, and you lose those 1-2s of
>>> audio. The hw silence mode is a way to keep the link active.
>> I see.  Yes, the feature would be useful.
>>
>>> But I guess we can remove first and re-add later so no objections.
>> Agreed.
>>
>> How would it be actually implemented?  Just avoid to turn off the
>> audio config bits at trigger callback, etc?
>>
>> Since the runtime PM will be in the same game, we'll have to cope with
>> it, too.
>I must admit I don't remember the details, just that's it's the same
>behavior as the HDAudio KAE (Keep Alive Enable) functionality.
>

I have this patch from the past. It won't apply with the recent changes
in the code. But the silence filling code can be used from there.

The idea was to use hardware functionality to generate silence
when the hotplug event is detected.


>>
>>
>> thanks,
>>
>> Takashi
>
>_______________________________________________
>Alsa-devel mailing list
>Alsa-devel at alsa-project.org
>http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Audio-Silence-fix.patch
Type: application/octet-stream
Size: 15718 bytes
Desc: 0001-Audio-Silence-fix.patch
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170203/6608d109/attachment-0001.obj>


More information about the Alsa-devel mailing list