[alsa-devel] [RFC v3 06/11] ASoC: hdac_hda: add ASoC based HDA codec driver

Mark Brown broonie at kernel.org
Wed Dec 20 11:26:25 CET 2017


On Tue, Dec 19, 2017 at 08:17:37PM +0100, Takashi Iwai wrote:

> Well, honestly speaking, that complete morphing scares me.  If it's a
> simple additional call, it's easier to track the code flow.  But your
> patch essentially fakes the legacy codec and bus structs and twists
> the control by that switch...  which looks too fragile to me.

Especially when it's layered on top of all the other x86 code which is
also complicated and fragile - feels like there's lots of places things
can go wrong and lots of potential unexpected interactions.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20171220/9d32b13a/attachment.sig>


More information about the Alsa-devel mailing list