[alsa-devel] [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

Timur Tabi timur at tabi.org
Sat Dec 16 05:43:14 CET 2017


On 12/13/17 5:18 PM, Nicolin Chen wrote:
> -	 * We are running on a SoC which does not support online SSI
> -	 * reconfiguration, so we have to enable all necessary flags at once
> -	 * even if we do not use them later (capture and playback configuration)
> +	 * Online configuration is not supported
> +	 * Enable or Disable all necessary bits at once

This is an example of a bad change, IMHO.  The original was written in 
elegant prose.  The new version is just two short sentences.


More information about the Alsa-devel mailing list