[alsa-devel] [PATCH 5/9] ASoC: max98927: Removed obsolete variables

Mark Brown broonie at kernel.org
Thu Aug 31 13:53:59 CEST 2017


On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee at maximintegrated.com>

Why are these variables obsolete?  If their use was removed in earlier
patches in the series they should be handled in that patch, if they're
just unused say so.  In general your changelogs could really benefit
from being a bit longer and explaining why changes are being made.

>  mode change 100644 => 100755 sound/soc/codecs/max98927.h

This also changes the permissions to be executable which isn't what we
want.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170831/fcb28e63/attachment.sig>


More information about the Alsa-devel mailing list