[alsa-devel] [PATCH 4/5] ASoC: dapm: Adjust one function call together with a variable assignment

SF Markus Elfring elfring at users.sourceforge.net
Thu Aug 10 15:04:05 CEST 2017


From: Markus Elfring <elfring at users.sourceforge.net>
Date: Thu, 10 Aug 2017 14:34:35 +0200

The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
---
 sound/soc/soc-dapm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 3fa9f023bff7..4eea84d821c4 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3441,7 +3441,8 @@ snd_soc_dapm_new_control_unlocked(struct snd_soc_dapm_context *dapm,
 	const char *prefix;
 	int ret;
 
-	if ((w = dapm_cnew_widget(widget)) == NULL)
+	w = dapm_cnew_widget(widget);
+	if (!w)
 		return NULL;
 
 	switch (w->id) {
-- 
2.14.0



More information about the Alsa-devel mailing list