[alsa-devel] [PATCH v2 2/2] ASoC: soc-core: Remove unneeded error check

Mark Brown broonie at kernel.org
Mon Aug 7 13:31:20 CEST 2017


On Mon, Aug 07, 2017 at 12:16:54AM -0300, Fabio Estevam wrote:

> "A NULL return value indicates that something went
> wrong.  If ERR_PTR(-ENODEV) is returned, that is an indication that the
> kernel has been built without debugfs support and none of the functions
> described below will work."

> As snd_soc_debugfs_init() is only defined when CONFIG_DEBUG_FS=y,
> there is no possibility for debugfs_create_dir() returning an error,
> so remove the unneeded error check.

Removing the error handling means that if in future it does start
returning errors we'll ignore them - it's not like the error handling is
getting in the way or otherwise causing problems, removing it isn't
making things better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170807/e8dc086e/attachment-0001.sig>


More information about the Alsa-devel mailing list