[alsa-devel] [PATCH -next] ASoC: Intel: Skylake: Fix to use list_for_each_safe() when delete items

weiyongjun (A) weiyongjun1 at huawei.com
Wed Apr 26 07:39:06 CEST 2017



> -----Original Message-----
> From: Vinod Koul [mailto:vinod.koul at intel.com]
> Sent: Wednesday, April 26, 2017 1:38 PM
> To: weiyongjun (A) <weiyongjun1 at huawei.com>
> Cc: Wei Yongjun <weiyj.lk at gmail.com>; Liam Girdwood
> <lgirdwood at gmail.com>; Mark Brown <broonie at kernel.org>; Jaroslav
> Kysela <perex at perex.cz>; Takashi Iwai <tiwai at suse.com>; Pardha Saradhi K
> <pardha.saradhi.kesapragada at intel.com>; G Kranthi
> <gudishax.kranthikumar at intel.com>; Hardik T Shah
> <hardik.t.shah at intel.com>; Jeeja KP <jeeja.kp at intel.com>; alsa-
> devel at alsa-project.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH -next] ASoC: Intel: Skylake: Fix to use
> list_for_each_safe() when delete items
> 
> On Tue, Apr 25, 2017 at 07:57:57AM +0000, weiyongjun (A) wrote:
> > > >
> > > > Since we will remove items off the list using list_del() we need
> > > > to use a safe version of the list_for_each() macro aptly named
> > > > list_for_each_safe().
> > >
> > > ah yes, god catch
> > >
> > > > This is detected by Coccinelle semantic patch.
> > >
> > > It is a good practice to include the script you used, do you mind adding
> > > that in the log?
> > >
> >
> > Sure.
> 
> Sorry I meant this should be in changelog of the patch :)

OK, I will add this and send the v2 version patch later.




More information about the Alsa-devel mailing list