[alsa-devel] [alsa-lib][PATCH 3/3] timer: obsolete legacy rtctimer instance

Takashi Sakamoto o-takashi at sakamocchi.jp
Fri Apr 21 17:15:17 CEST 2017


On Apr 22 2017 00:08, Takashi Sakamoto wrote:
> At v4.7 development, ALSA timer interface dropped device instance based on
> legacy rtctimer implementation. User space applications should not use the
> device instance.
>
> This commit drops a macro corresponding to the instance.

Oops. This patch doesn't drop it... I should have written that 'This 
commit adds comments to notify a corresponding macro should not be used 
anymore.'

Hmm. It's better for me to post v2 patchset...

> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> ---
>  include/sound/asound.h | 2 +-
>  include/timer.h        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/sound/asound.h b/include/sound/asound.h
> index 9887361..fb8d7d7 100644
> --- a/include/sound/asound.h
> +++ b/include/sound/asound.h
> @@ -675,7 +675,7 @@ enum {
>
>  /* global timers (device member) */
>  #define SNDRV_TIMER_GLOBAL_SYSTEM	0
> -#define SNDRV_TIMER_GLOBAL_RTC		1
> +#define SNDRV_TIMER_GLOBAL_RTC		1	/* unused */
>  #define SNDRV_TIMER_GLOBAL_HPET		2
>  #define SNDRV_TIMER_GLOBAL_HRTIMER	3
>
> diff --git a/include/timer.h b/include/timer.h
> index 2803f53..8b8a8ea 100644
> --- a/include/timer.h
> +++ b/include/timer.h
> @@ -112,7 +112,7 @@ typedef struct _snd_timer_tread {
>  /** global timer - system */
>  #define SND_TIMER_GLOBAL_SYSTEM 0
>  /** global timer - RTC */
> -#define SND_TIMER_GLOBAL_RTC 	1
> +#define SND_TIMER_GLOBAL_RTC	1	/* unused */
>  /** global timer - HPET */
>  #define SND_TIMER_GLOBAL_HPET	2
>  /** global timer - HRTIMER */


Regards

Takashi Sakamoto


More information about the Alsa-devel mailing list