[alsa-devel] [PATCH v4 6/9] ASoC: add snd_soc_get_dai_id()

[Kuninori Morimoto]

Hi Rob

> > ports {
> >         port { endpoint }; /* ID = 0 */
> >         port { endpoint }; /* ID = 1 */
> >         port { endpoint }; /* ID = 2 */
> 
> These ports are audio channels? If these are 3 separate data paths,
> then this is correct. If you have a single data path with multiple
> connections (e.g. a mux), then that should be a single port with
> multiple endpoints. For example, a design that routes the same I2S
> interface to HDMI and a codec and their use is mutually exclusive. I
> imagine you will need to support both.

Thanks.
Maybe we wil need it in the future, but not yet supported now.

> The pattern I prefer to see calling graph functions is that drivers
> are specific about which port and endpoint number for a parent node
> they want. Not just searching the graph for any match.

This related feature will be needed on HDMI sound support,
because it has not only sound port/endpoint.

> > 1 question
> >
> > It will support HDMI sound feature, thus I separated
> > it into OF-graph (= this patch-set) and HDMI (= next patch-set).
> > Should I merge it ?
> 
> I think so if it affects the functions here. It seems better to let
> the driver controlling the DAI determine the id mapping than trying to
> do it in the core.

At this point, this feature (= HDMI sound) is not needed for OF-graph
patch-set. Thus, as-is is OK for OF-graph patch-set ?

Best regards
---
Kuninori Morimoto