[alsa-devel] [PATCH v2 1/5] ASOC: da7219: fix inappropriate condition statement

[Takashi Sakamoto]

Mark,

On Sep 27 2016 07:45, Takashi Sakamoto wrote:
> Sparse reports a below warning.
> 
> sound/soc/codecs/da7219.c:804:57: warning: dubious: x & !y
> 
> The line includes a condition statement; '(a < b) & !c'. Practically, the
> evaluated value of this statement equals to the value of '(a < b) && !c'.
> Although, it's not an usual way to use bitwise operations as logical
> operations to several conditions.
> 
> This commit fixes the bug.
> 
> Fixes: 6d817c0e9fd7 ("ASoC: codecs: Add da7219 codec driver")
> Acked-by: Adam Thomson <Adam.Thomson.Opensource at diasemi.com>
> Cc: Support Opensource <support.opensource at diasemi.com>
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> ---
>  sound/soc/codecs/da7219.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index 50ea943..b9fa8fe 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -801,7 +801,7 @@ static int da7219_dai_event(struct snd_soc_dapm_widget *w,
>  				++i;
>  				msleep(50);
>  			}
> -		} while ((i < DA7219_SRM_CHECK_RETRIES) & (!srm_lock));
> +		} while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock));
>  
>  		if (!srm_lock)
>  			dev_warn(codec->dev, "SRM failed to lock\n");

I have never received your 'applied' message to this patch, while
received the others.

This patch should be abandoned? or I should send v2 with corrected
subject line?


Regards

Takashi Sakamoto