[alsa-devel] [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path

Nikita Yushchenko nikita.yoush at cogentembedded.com
Mon Sep 26 18:11:10 CEST 2016



26.09.2016 19:08, Mark Brown пишет:
> On Mon, Sep 26, 2016 at 01:35:50PM +0300, Nikita Yushchenko wrote:
> 
>> I doubt that copying 7 lines into error path is better than having a tiny
>> logic with return values, but still here it is.
> 
> Consider what happens if someone wants to change the code... 

I believe that "undo poweron" and "poweroff" sequences still will have
to remain the same. This having two copies of code is more error-prone
than having one.

Nikita


More information about the Alsa-devel mailing list