[alsa-devel] [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache

Maciej S. Szmigiero mail at maciej.szmigiero.name
Fri Sep 23 01:38:24 CEST 2016


On 22.09.2016 17:27, Marek Vasut wrote:
> On 09/22/2016 04:37 PM, Maciej S. Szmigiero wrote:
>> On 22.09.2016 12:45, Mark Brown wrote:
>>> On Thu, Sep 22, 2016 at 01:33:47AM +0200, Maciej S. Szmigiero wrote:
>>>
(..)
>> It looks to me 1) is an easier and safer solution, especially that
>> the driver previously worked fine with RB tree cache.
>> I would test this myself but unfortunately I don't have access to
>> hardware this week.
> 
> I believe switching to flat cache is harmless and it should be a better
> mode for devices with small mmio address spaces. After some discussion
> on IRC, I believe [1] should resolve the RBTREE crash (?).
> 
> [1]
> http://git.kernel.org/cgit/linux/kernel/git/broonie/regmap.git/commit/?h=for-next&id=b2c7f5d9c939a37c1ce7f86a642de70e3033ee9e

I assume you meant "flat cache crash" not "RBTREE crash".

I will test flat cache version with this patch as soon as I get
my UDOO board back (probably next week) - maybe everything will be
fine.

Maciej



More information about the Alsa-devel mailing list