[alsa-devel] [PATCH] ALSA: line6: fix ifnullfree.cocci warnings

kbuild test robot fengguang.wu at intel.com
Tue Sep 20 02:10:13 CEST 2016


sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Andrej Krutak <dev at andree.sk>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 driver.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/sound/usb/line6/driver.c
+++ b/sound/usb/line6/driver.c
@@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca
 	/* Free buffer memory first. We cannot depend on the existence of private
 	 * data from the (podhd) module, it may be gone already during this call
 	 */
-	if (line6->buffer_message)
-		kfree(line6->buffer_message);
+	kfree(line6->buffer_message);
 
 	kfree(line6->buffer_listen);
 


More information about the Alsa-devel mailing list