[alsa-devel] [PATCH 1/4] ASoC: rt286: rt286_mic_detect() uses component

Vinod Koul vinod.koul at intel.com
Wed Oct 26 18:08:43 CEST 2016


On Wed, Oct 26, 2016 at 08:56:15AM +0200, Lars-Peter Clausen wrote:
> On 10/26/2016 05:50 AM, Vinod Koul wrote:
> >>
> >> Maybe somebody from the Intel side can look into fixing this. The affected
> >> boards are cht_bsw_rt5672 and broadwell, which both access the cards
> >> codec_dev_list field.
> > 
> > This also exists in some customer SKL machines.
> > 
> > I agree that this may not be best implementation so I can send a patch for
> > this.
> > 
> > As Lars suggested we can use DAI link init callback, but then I dont feel it
> > is right to use rtd->codec to get codec pointer, again we will be looking
> > into rtd internals. So would make sense to combine two suggestion and add an
> > API:
> > 
> > struct snd_soc_codec *snd_soc_get_codec(struct snd_soc_pcm_runtime *rtd)
> > {
> > 	return rtd->codec;
> > }
> 
> I've started working on this series[1] a while ago with the intention of
> eventually removing the CODEC field from the rtd struct. Maybe you can use
> it as a base.

Sure thing :)

-- 
~Vinod


More information about the Alsa-devel mailing list