[alsa-devel] [PATCH v2 5/7] ALSA: hda - Use ops instead of directly accessing chmap helpers

Takashi Iwai tiwai at suse.de
Thu Mar 3 12:39:05 CET 2016


On Thu, 03 Mar 2016 12:29:23 +0100,
Vinod Koul wrote:
> 
> On Wed, Mar 02, 2016 at 05:03:10PM +0100, Takashi Iwai wrote:
> > On Wed, 02 Mar 2016 13:03:26 +0100,
> > Subhransu S. Prusty wrote:
> > > 
> > > Added more ops to the chmap object, so most of the helpers can be
> > > accessed through ops instead instead of directly calling them.
> > 
> > Too many instead :)
> > 
> > > With this moving the chmap helpers to core will be easy.
> > 
> > Well, although I asked about reduction of exported stuff, I don't
> > think it's worth to put everything in ops.  If any of them would be
> > overridden, it's good to have as an ops.  If not, it's fine to have
> > exported symbols.  These are just a few entries, not over 20.
> 
> I think the thought was that patch_hdmi and ASoC driver will use defaults
> whereas the patch_nvidia etc will override with their own stuff..

Yes, but are these new ops overridden actually?


Takashi


More information about the Alsa-devel mailing list