[alsa-devel] [PATCH v2 3/7] ALSA: hda - Use hdmi name space for CEA spk alloc structure

Takashi Iwai tiwai at suse.de
Wed Mar 2 17:09:48 CET 2016


On Wed, 02 Mar 2016 13:03:24 +0100,
Subhransu S. Prusty wrote:
> 
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty at intel.com>
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>

A slight concern is that the code we have is specific to HD-audio
while the header and symbols don't indicate it in your patch.
If it were designed for a generic purpose HDMI/DP, it's fine.  But the
current code appears fairly specific to HDA, so it should be a bit
more uniquely prefixed, I suppose, since there are some other parallel
developments regarding HDMI for other platforms.


thanks,

Takashi


More information about the Alsa-devel mailing list