[alsa-devel] [PATCH] ASoC: codecs: Remove "select REGMAP_SPI/REGMAP_I2C"

[Mark Brown]

On Thu, Jun 16, 2016 at 09:31:18PM +0200, Lars-Peter Clausen wrote:
> On 06/16/2016 09:00 PM, Alexander Shiyan wrote:
> > REGMAP_SPI and REGMAP_I2C is selected automatically by SND_SOC,
> > so no additional actions is required.

> To be honest I'd rather have this the other way around. Remove them from
> SND_SOC and let every CODEC select them individually. That would be the
> technically correct approach.

Indeed.

> Otherwise if we want argue that a system using ASoC has probably at least
> one CODEC device that either regmap SPI or regmap I2C and that's why it
> makes sense for them to be selected automatically, we can also argue that
> these days any system that has SPI or I2C support has likely one device that
> either uses regmap SPI or regmap I2C, so they should always be enabled.

Well, the reason it's selected at present is that the core has some
regmap code (but that just needs plain regmap) and the legacy code for
the old ASoC I/O being backed by regmap.  We should be able to at least
drop back to just selecting regmap alone at this point, restructuring
the code so we only include the regmap bits in the core if regmap is
selected is probably more trouble than it's worth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160617/a61a35ef/attachment.sig>