[alsa-devel] Support Dell headset mode for ALC891

[Kailang]

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de] 
> Sent: Monday, June 13, 2016 3:29 PM
> To: Kailang
> Cc: (alsa-devel at alsa-project.org)
> Subject: Re: Support Dell headset mode for ALC891
> 
> On Mon, 13 Jun 2016 09:24:45 +0200,
> Kailang wrote:
> > 
> >  
> > 
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai at suse.de]
> > > Sent: Thursday, June 09, 2016 2:15 PM
> > > To: Kailang
> > > Cc: (alsa-devel at alsa-project.org)
> > > Subject: Re: Support Dell headset mode for ALC891
> > > 
> > > On Wed, 08 Jun 2016 09:17:12 +0200,
> > > Kailang wrote:
> > > > 
> > > > Hi Takashi,
> > > > 
> > > > This patch is supported Dell headset mode for ALC891.
> > > > It is only support I-phone type headset.
> > > > I think this function is only support for DELL.
> > > > So, headset mode and platform support is merged.
> > > > 
> > > > This patch is test passed by Ubuntu team.
> > > > 
> > > > Many Thanks.
> > > (snip)
> > > > Date: Tue, 7 Jun 2016 11:31:34 +0800
> > > > Subject: [PATCH] ALSA: hda/realtek - ALC891 headset 
> mode for Dell
> > > >
> > > > New headset mode of ALC891 for Dell.
> > > > 
> > > > Signed-off-by: Kailang Yang <kailang at realtek.com>
> > > 
> > > Could you put more comments in the changelog, as what you gave in 
> > > the mail?
> > > 
> >        OK.
> > > 
> > > > diff --git a/sound/pci/hda/patch_realtek.c 
> > > > b/sound/pci/hda/patch_realtek.c index 7960316..9dc641e 100644
> > > > --- a/sound/pci/hda/patch_realtek.c
> > > > +++ b/sound/pci/hda/patch_realtek.c
> > > > @@ -3718,6 +3718,9 @@ static void
> > > alc_headset_mode_unplugged(struct hda_codec *codec)
> > > >  	case 0x10ec0295:
> > > >  		alc_process_coef_fw(codec, coef0225);
> > > >  		break;
> > > > +	case 0x10ec0867:
> > > > +		alc_update_coefex_idx(codec, 0x57, 0x5, 
> 1<<14, 0);
> > > > +		break;
> > > >  	}
> > > >  	codec_dbg(codec, "Headset jack set to unplugged
> > > mode.\n");  } @@
> > > > -3805,6 +3808,8 @@ static void
> > > alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
> > > >  		alc_process_coef_fw(codec, coef0293);
> > > >  		snd_hda_set_pin_ctl_cache(codec, 
> mic_pin, PIN_VREF50);
> > > >  		break;
> > > > +	case 0x10ec0867:
> > > > +		alc_update_coefex_idx(codec, 0x57, 0x5, 
> 0, 1<<14);
> > > > 	case 0x10ec0662:
> > > 
> > > No break between 0867 and 0662?
> > 
> > Yes, no break. ^^
> > It is only more one line difference for 0x0867.
> 
> Then please put a comment indicating it's a fall-through, e.g.
> 
> 	case 0x10ec0867:
> 		alc_update_coefex_idx(codec, 0x57, 0x5, 0, 1<<14);
> 		/* fallthru */
>  	case 0x10ec0662:
> 		....

OK. Thanks. ^^

> 
> 
> Takashi
> 
> ------Please consider the environment before printing this e-mail.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dell-headset-mode-for-alc891.patch
Type: application/octet-stream
Size: 4202 bytes
Desc: 0001-dell-headset-mode-for-alc891.patch
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160613/e428c840/attachment.obj>