[alsa-devel] [PATCH 3/3] ASoC: Intel: Add surface3 entry in CHT-RT5645 machine

[Mokashi, SachinX]

Mark Brown is the maintainer of sound tree. He is included in cc: broonie at kernel.org :)

-----Original Message-----
From: Bastien Nocera [mailto:hadess at hadess.net] 
Sent: Wednesday, July 20, 2016 4:57 PM
To: Koul, Vinod <vinod.koul at intel.com>
Cc: alsa-devel at alsa-project.org; broonie at kernel.org; liam.r.girdwood at linux.intel.com; Patches Audio <patches.audio at intel.com>; Stephen Just <stephenjust at gmail.com>; Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>; apterix at gmail.com; bugzilla at hadess.net; Mokashi, SachinX <sachinx.mokashi at intel.com>
Subject: Re: [PATCH 3/3] ASoC: Intel: Add surface3 entry in CHT-RT5645 machine

On Wed, 2016-07-20 at 09:28 +0530, Vinod Koul wrote:
> On Tue, Jul 19, 2016 at 04:56:24PM +0200, Bastien Nocera wrote:
> > > +	/* fixup codec name based on HID */
> > > +	i2c_name = sst_acpi_find_name_from_hid(mach->id);
> > > +	if (i2c_name != NULL) {
> > > +		snprintf(cht_rt5640_codec_name,
> > > sizeof(cht_rt5640_codec_name),
> > > +			"%s%s", "i2c-", i2c_name);
> > > +		cht_dailink[dai_index].codec_name =
> > > cht_rt5640_codec_name;
> > 
> > FWIW, I get:
> > sound/soc/intel/boards/cht_bsw_rt5645.c: In function
> > 'snd_cht_mc_probe':
> > sound/soc/intel/boards/cht_bsw_rt5645.c:391:37: warning:
> > 'dai_index' may be used uninitialized in this function [-Wmaybe- 
> > uninitialized]
> >    cht_dailink[dai_index].codec_name = cht_rt5640_codec_name;
> >    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
> 
> Yeah I notice them a bit later. The fixes are already in mark's-next.

Care to be a bit more specific. Kind of hard to know which Mark you're talking about when there's no one of that name in the CC: list above.