[alsa-devel] [PATCH v2 0/3] Remove support for SNDRV_CTL_ELEM_ACCESS_USER & minor fix

[Mengdong Lin]

On 07/20/2016 12:29 PM, Takashi Sakamoto wrote:
> Hi,
>
> On Jul 20 2016 10:52, mengdong.lin at linux.intel.com wrote:
>> From: Mengdong Lin <mengdong.lin at linux.intel.com>
>>
>> There is no ABI change in this series.
>>
>> Remove support for control flag SNDRV_CTL_ELEM_ACCESS_USER as Takashi
>> Sakamoto suggested. Also fix 2 compiler warnings and add check before
>> string cpy.
>>
>> History:
>> v2: Revise commit messages.
>>
>> Mengdong Lin (3):
>>    topology: Remove support for control flag SNDRV_CTL_ELEM_ACCESS_USER
>>    topology: Add ATTRIBUTE_UNUSED for unused parameters to fix compiler
>>      warning
>>    topology: Check address and length before string copy
>>
>>   src/topology/ctl.c        | 1 -
>>   src/topology/pcm.c        | 8 ++++----
>>   src/topology/tplg_local.h | 3 +++
>>   3 files changed, 7 insertions(+), 5 deletions(-)
>
> Reviewed-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
>
> But I believe that we can seek better ways for the purpose of third
> patch. For example, changing prototype of the function to return error
> code might help callers to handle errors appropriately.
>
> Anyway, thanks for the first patch.
>

The 3rd patch is to reduce checking on some optional fields elsewhere. 
We could drop this patch if we add check before calling elem_copy_text() 
and it will bring more code.

Thanks
Mengdong