[alsa-devel] [PATCH 1/7] ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name()

[Mark Brown]

On Wed, Jul 06, 2016 at 10:01:27AM +0900, Kuninori Morimoto wrote:

> +	if (name) {
> +		ret = 0;
> +
> +		dai_link->name =
> +		dai_link->stream_name = name;
> +	}

This code is unclear - it's valid C but the line break in the middle of
the set of assignments makes it look like the first assignment is an
error.  This should be two assignments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160708/13ffbfb3/attachment.sig>