[alsa-devel] [PATCH alsa-lib 1/3] pcm: Remove superfluous rmb() from PCM meter plugin

Takashi Iwai tiwai at suse.de
Thu Jul 7 16:30:07 CEST 2016


rmb() is still left in the code without any actual meaning there just
before the atomic operation.  Let's clean it up.

Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
 src/pcm/pcm_meter.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/pcm/pcm_meter.c b/src/pcm/pcm_meter.c
index 1b0ccb40b3dd..d71af7a683e0 100644
--- a/src/pcm/pcm_meter.c
+++ b/src/pcm/pcm_meter.c
@@ -136,7 +136,6 @@ static int snd_pcm_meter_update_scope(snd_pcm_t *pcm)
  _again:
 	rptr = *pcm->hw.ptr;
 	old_rptr = meter->rptr;
-	rmb();
 	if (atomic_read(&meter->reset)) {
 		reset = 1;
 		atomic_dec(&meter->reset);
-- 
2.9.0



More information about the Alsa-devel mailing list