[alsa-devel] [PATCH 07/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()

[Kuninori Morimoto]

Hi Mark, again

sorry previous was not good question

> > > > > +	if (!card->name)
> > > > > +		card->name = card->dai_link->name;
> > 
> > > > This will unconditionally defererence dai_link but it's optional - we
> > > > can have analogue only cards.
> > 
> > > This is not new feature. Current simple-card already has it.
> > 
> > Right, but simple-card does need DAIs IIRC while this is intended to be
> > more general.  All it needs is a check before the dereference to be safe
> > so it's trivial to handle.
> 
> Sorry, I'm not 100% understand.
> Do you mean we don't need handle card->name ? (= we should remove above ?)
> If so, we can't register card on simple-card. Because snd_soc_register_card()
> requests it.

This function tries to get card name from snd_soc_of_parse_card_name().
and it tries to set card->name from dai_link if card still doesn't have name.
So, above is optional 2nd try.
Or, do you mean this if (!card->name) can goes to simple-card, instead of utils ?
I have no objection about it , but it can be double handling ?
Because other simple family have same situation.