[alsa-devel] [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk

Mark Brown broonie at kernel.org
Fri Jan 29 00:15:23 CET 2016


On Thu, Jan 28, 2016 at 04:54:20PM +0000, Damien Horsley wrote:

> +	ret = clk_set_rate(pcm3168a->scki, freq);
> +	if (ret)
> +		return ret;
> +
>  	pcm3168a->sysclk = freq;

Since the clock appears to be mandatory in this driver (good!) why are
we even storing sysclk?  Just remove it, the driver never actually used
it anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160129/24acb950/attachment.sig>


More information about the Alsa-devel mailing list