[alsa-devel] [RFC PATCH 3/3] ASoC: pcm179x: Add support for pcm1795 and pcm1796

[Mark Brown]

On Sun, Jan 10, 2016 at 12:38:05AM +0100, Michael Trimarchi wrote:

> +	if (priv->codec_model == PCM1795)
> +		formats = PCM1795_FORMATS;

This should be a switch statement to handle any future variations.

>  static const struct of_device_id pcm179x_of_match[] = {
>  	{ .compatible = "ti,pcm1792a", },
> +	{ .compatible = "ti,pcm1796", },
> +	{ .compatible = "ti,pcm1795",
> +	  .data = &codec_model,
> +	},

Please keep tables sorted, it avoid conflicts and merge issues when
adding new entries.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160110/a42d0c1e/attachment.sig>