[alsa-devel] [PATCH 4/4] ALSA: hda - hdmi monitor hotplug support for dynamic pcm assignment

[Yang, Libin]

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Friday, January 08, 2016 3:45 PM
> To: Yang, Libin
> Cc: libin.yang at linux.intel.com; alsa-devel at alsa-project.org; Lin,
> Mengdong
> Subject: Re: [alsa-devel] [PATCH 4/4] ALSA: hda - hdmi monitor hotplug
> support for dynamic pcm assignment
> 
> On Fri, 08 Jan 2016 06:25:37 +0100,
> Yang, Libin wrote:
> >
> > Hi Takashi,
> >
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai at suse.de]
> > > Sent: Thursday, January 07, 2016 10:18 PM
> > > To: libin.yang at linux.intel.com
> > > Cc: alsa-devel at alsa-project.org; Lin, Mengdong; Yang, Libin
> > > Subject: Re: [alsa-devel] [PATCH 4/4] ALSA: hda - hdmi monitor
> hotplug
> > > support for dynamic pcm assignment
> > >
> > > On Thu, 31 Dec 2015 02:22:22 +0100,
> > > libin.yang at linux.intel.com wrote:
> > > >
> > > > From: Libin Yang <libin.yang at linux.intel.com>
> > > >
> > > > This patch adds the support for monitor hotplug of dynamic pcm
> > > assignment.
> > > >
> > > > 1. unsol_event enabling
> > > >  - For codec_has_acomp, unsol_event is disabled.
> > > >  - For !codec_has_acomp && !dyn_pcm_assign, use the hda_jack
> > > helper to
> > > >    enable unsol_event
> > > >  - For !codec_has_acomp && dyn_pcm_assign, enable unsol_event
> > > with verb
> > > >    directly
> > > >
> > > > 2. unsol_event handling
> > > >  - For !dyn_pcm_assign, use hda_jack helper to report the event
> > > >  - For dyn_pcm_assign, use snd_jack_report() directly
> > >
> > > I guess we can reduce lots of codes if ignoring the case with
> > > dyn_pcm_assign but without audio component?  If so, for simplicity,
> we
> > > can limit dyn_pcm_assign only tied with audio component.  Just add a
> > > WARN_ON() in such a case.  Although the functionality is somehow
> > > unrelated, the actual testing and coding is more targeted with Intel
> > > chips that are only with audio component.
> >
> > My initial idea is to support:
> > 1. dyn_pcm_assign && acomp: Intel case
> > 2. dyn_pcm_assign && !acomp: other vendors MST case
> > 3. !dyn_pcm_assign && acomp: Intel non-mst case
> > 4. !dyn_pcm_assign && !acomp: other vendors current case
> >
> > Do you mean we can ignore other vendors' case so far? If so, the
> > code will be simpler.
> 
> Yes.  And give WARN_ON(dyn_pcm_assign && !acomp);

Get it. I will follow it.

Regards,
Libin

> 
> 
> Takashi