[alsa-devel] [PATCH 2/3] ASoC: rt298: clear IRQ at the beginning of rt298_irq

Bard Liao bardliao at realtek.com
Wed Feb 24 03:59:23 CET 2016


> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Wednesday, February 17, 2016 9:20 PM
> To: Bard Liao
> Cc: lgirdwood at gmail.com; alsa-devel at alsa-project.org;
> lars at metafoo.de; Flove; Oder Chiou; John Lin; ramesh.babu at intel.com;
> senthilnathanx.veppur at intel.com
> Subject: Re: [PATCH 2/3] ASoC: rt298: clear IRQ at the beginning of
> rt298_irq
> 
> On Tue, Feb 16, 2016 at 05:12:35PM +0800, Bard Liao wrote:
> 
> > The IRQ pin will go from high to low when the irq bit is clear.
> > To let the IRQ pin go low as early as possible, move the clear irq bit
> > function to the beginning of irq handler.
> 
> Why is this a benefit?  We're going to mask the interrupt as long as the
> interrupt handler is running anyway.

Thanks for your reminding. There is actually no benefit on the patch.
Can you ignore this patch and apply other two patches?
Or I should send the patches again?

> 
> ------Please consider the environment before printing this e-mail.


More information about the Alsa-devel mailing list