[alsa-devel] [RFC 4/4] ASoC: Change soc-card codec_conf array to a list

[Mark Brown]

On Mon, Feb 15, 2016 at 05:49:32PM +0530, Vaibhav Agarwal wrote:

> +void snd_soc_add_codec_config(struct snd_soc_card *card,
> +			      struct snd_soc_codec_conf *codec_conf)
> +{
> +	mutex_lock(&client_mutex);
> +	list_add_tail(&codec_conf->list, &card->codec_conf_list);
> +	mutex_unlock(&client_mutex);
> +}

We add a configuration but we don't act on it?  That's surprising...  I
don't really have a sense of how in concrete terms this interface is
intended to work.

> +EXPORT_SYMBOL(snd_soc_add_codec_config);

All ASoC APIs are _GPL.

> +	/* add predefined codec_configs to the list */
> +	for (i = 0; i < card->num_configs; i++)
> +		snd_soc_add_codec_config(card, card->codec_conf+i);
> +

Coding style.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160215/5d9133fe/attachment.sig>