[alsa-devel] [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT

Charles Keepax ckeepax at opensource.wolfsonmicro.com
Thu Feb 4 13:46:44 CET 2016


On Tue, Feb 02, 2016 at 07:30:02PM +0000, Mark Brown wrote:
> On Tue, Feb 02, 2016 at 04:38:04PM +0000, Charles Keepax wrote:
> 
> > +#define ARIZONA_48K_RATES 12000, 24000, 48000, 96000, 192000, 4000, 8000, \
> > +			  16000, 32000
> 
> This just looks wrong.  It's valid code but with the combination of the
> split line and the list without any sort of parenthesis it sets off
> alarm bells.  Duplicating might not be the worst thing ever...

I will respin with just duplicating the rates lists, I am happy
enough with that.

Thanks,
Charles


More information about the Alsa-devel mailing list