[alsa-devel] [PATCH][alsa-lib] topology: fix unused-const-variable warning

[Lin, Mengdong]

> -----Original Message-----
> From: Takashi Sakamoto [mailto:o-takashi at sakamocchi.jp]
> Sent: Friday, December 23, 2016 11:34 PM
> >>>
> >>> Hi Liam,
> >>>
> >>> This "widget_control_map" is still unused now.
> >>>
> >>> Could you remember why we define this map in the early phase?
> >>> I guess previously we want to distinguish stand-alone controls from
> controls embedded in widgets. But now we process them in the same way,
> both in user space and kernel.
> >>>
> >>> So I feel we can remove this structure.
> >>
> >> Additionally, would you check this post to fix some warnings which
> >> you added into alsa-lib, please.
> >> [alsa-devel] [PATCH][alsa-lib] topology: fix sign-compare warning
> >> introduced to set_link_hw_config() and tplg_add_link_object()
> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/11
> >> 5896.html
> >>
> >>
> >
> > Both look good to me. Apologies that I missed them.
> >
> > You may want to resend them both with my Ack (maybe wait for until
> > after Christmas though).
> 
> No need. Iwai-san already reviewed them. Next year, I'll request him to apply
> them.
> http://mailman.alsa-project.org/pipermail/alsa-devel/2016-
> December/115725.html
> 
> I request Mengdong-Lin to care of compiler warnings again. Her patches
> frequently bring this kind of mistakes, and I have no motivations to fix them
> anymore.

Sorry for this. I'll be careful on the warnings.

To avoid the same issue for UCM, I submitted patches to add '-Wall' to the AM_CPPFLAGS for topology, so we can always see the warnings and fix them.
If this is acceptable for ucm, I'll also enable all warnings for topology as well.

Thanks
Mengdong