[alsa-devel] [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()

Michał Kępień kernel at kempniu.pl
Thu Dec 15 15:48:16 CET 2016


> On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> > On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar at gmail.com> wrote:
> >> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
> >>> All calls to dell_app_wmi_led_set() have been replaced with direct
> >>> calls to dell_micmute_led_set(), so the former can be safely removed
> >>> along with its related enum.
> >>>
> >>> Signed-off-by: Michał Kępień <kernel at kempniu.pl>
> >>
> >> I would suggest to squash patches 2,3,4 into one. But I let decision to
> >> alsa & led maintainers.
> >
> > I don't like the part where we are exporting something for just one
> > moment.
> 
> Oops, misread function name, though still valid vote for one patch.

Thanks, I will do that in v2 (and thanks to Pali for suggesting it).

-- 
Best regards,
Michał Kępień


More information about the Alsa-devel mailing list