[alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: fallback mechanism if MCLK is not enabled

[Mark Brown]

On Tue, Dec 13, 2016 at 12:41:30PM -0600, Pierre-Louis Bossart wrote:
> Commit df1a2776a795 ("ASoC: Intel: bytcr_rt5640: add MCLK support")
> was merged but the corresponding clock framework patches have not,
> after being bumped from audio to clock to x86 domains. The missing
> clock-related patches result in a regression starting with 4.9 with
> the audio card not being created.

When I asked about this previously you said that this only affected new
boards?

>  			dev_err(&pdev->dev,
>  				"Failed to get MCLK from pmc_plt_clk_3: %ld\n",
>  				PTR_ERR(priv->mclk));
> -			return PTR_ERR(priv->mclk);
> +
> +			/* Fall back to bitclock only */
> +			byt_rt5640_quirk &= ~BYT_RT5640_MCLK_EN;

This is broken for probe deferral, I'd expect this to be explicitly
checking for a no clock mapped error code (probably -ENOENT) rather than
just ignoring all errors.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20161214/b4984b55/attachment.sig>