[alsa-devel] [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86

Andy Shevchenko andy.shevchenko at gmail.com
Tue Dec 13 00:43:31 CET 2016


I have been told I have to send my comments here instead of our
internal ML. I didn't fast enough to comment that during v5. So do it
right now.

On Fri, Dec 9, 2016 at 8:01 PM, Irina Tirdea <irina.tirdea at intel.com> wrote:
> The pmc_atom driver does not contain any architecture specific
> code. It only enables the SOC Power Management Controller Driver

SOC -> SoC
Driver -> driver

> for BayTrail and CherryTrail platforms.
>
> Move the pmc_atom driver from arch/x86/platform/atom to
> drivers/platform/x86.
>
> Signed-off-by: Irina Tirdea <irina.tirdea at intel.com>
> ---
>  arch/x86/Kconfig                                                     | 4 ----
>  arch/x86/platform/atom/Makefile                                      | 1 -
>  drivers/acpi/acpi_lpss.c                                             | 2 +-
>  drivers/platform/x86/Kconfig                                         | 4 ++++
>  drivers/platform/x86/Makefile                                        | 1 +
>  {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c          | 3 +--

>  {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0

No, it's not a *platform data*.

Other that that looks good to me.

-- 
With Best Regards,
Andy Shevchenko


More information about the Alsa-devel mailing list