[alsa-devel] [PATCH 09/14] ASoC: max9867: remove unused ‘ret’

Fabio Estevam festevam at gmail.com
Thu Dec 8 23:48:49 CET 2016


On Thu, Dec 8, 2016 at 3:31 PM, Vinod Koul <vinod.koul at intel.com> wrote:

> -       ret = regmap_write(max9867->regmap, MAX9867_IFC1A, iface1A);
> -       ret = regmap_write(max9867->regmap, MAX9867_IFC1B, iface1B);
> +       regmap_write(max9867->regmap, MAX9867_IFC1A, iface1A);
> +       regmap_write(max9867->regmap, MAX9867_IFC1B, iface1B);

What about doing like this instead?

ret = regmap_write(max9867->regmap, MAX9867_IFC1A, iface1A);
if (ret)
    return ret;

ret = regmap_write(max9867->regmap, MAX9867_IFC1B, iface1B);
if (ret)
  return ret;

return 0;


More information about the Alsa-devel mailing list