[alsa-devel] [PATCH] ASoC: cs35l34: Simplify the logic to set CS35L34_MCLK_CTL setting

[Paul Handrigan]

On Sat, 3 Dec 2016, Axel Lin wrote:

> The logic of "value = ~CS35L34_MCLK_DIV & CS35L34_MCLK_RATE_XXXXXX;" is
> unnecessary complex. By setting CS35L34_MCLK_DIV | CS35L34_MCLK_RATE_MASK
> as the mask for regmap_update_bits() call, what the code does is exactly
> the same as setting value = CS35L34_MCLK_RATE_XXXXXX.
> 
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
> ---
>  sound/soc/codecs/cs35l34.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c
> index e0f672a..7c5d151 100644
> --- a/sound/soc/codecs/cs35l34.c
> +++ b/sound/soc/codecs/cs35l34.c
> @@ -610,15 +610,15 @@ static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai,
>  
>  	switch (freq) {
>  	case CS35L34_MCLK_5644:
> -		value = ~CS35L34_MCLK_DIV & CS35L34_MCLK_RATE_5P6448;
> +		value = CS35L34_MCLK_RATE_5P6448;
>  		cs35l34->mclk_int = freq;
>  	break;
>  	case CS35L34_MCLK_6:
> -		value = ~CS35L34_MCLK_DIV & CS35L34_MCLK_RATE_6P0000;
> +		value = CS35L34_MCLK_RATE_6P0000;
>  		cs35l34->mclk_int = freq;
>  	break;
>  	case CS35L34_MCLK_6144:
> -		value = ~CS35L34_MCLK_DIV & CS35L34_MCLK_RATE_6P1440;
> +		value = CS35L34_MCLK_RATE_6P1440;
>  		cs35l34->mclk_int = freq;
>  	break;
>  	case CS35L34_MCLK_11289:

Acked-by: Paul Handrigan <Paul.Handrigan at cirrus.com>