[alsa-devel] [PATCH v3 1/2] ALSA: firewire-tascam: accessing to user space outside spinlock

Takashi Iwai tiwai at suse.de
Wed Aug 31 14:25:29 CEST 2016


On Wed, 31 Aug 2016 13:15:32 +0200,
Takashi Sakamoto wrote:
> 
> In hwdep interface of firewire-tascam driver, accessing to user space is
> in a critical section with disabled local interrupt. Depending on
> architecture, accessing to user space can cause page fault exception. Then
> local processor stores machine status and handle the synchronous event. A
> handler corresponding to the event can call task scheduler to wait for
> preparing pages. In a case of usage of single core processor, the state to
> disable local interrupt is worse because it doesn't handle usual interrupts
> from hardware.
> 
> This commit fixes this bug, by performing the accessing outside spinlock.
> 
> Reported-by: Vaishali Thakkar <vaishali.thakkar at oracle.com>
> Cc: stable at vger.kernel.org
> Fixes: e5e0c3dd257b('ALSA: firewire-tascam: add hwdep interface')
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied this one now, as it's an individual fix.  Please resubmit only
the second patch once when fixed.


thanks,

Takashi


More information about the Alsa-devel mailing list