[alsa-devel] [PATCH 3/8] ASoC: simple-scu-card: tidyup codec daifmt handling method

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Aug 25 03:57:04 CEST 2016


From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

Current simple-scu-card is handling codec daifmt by using
for_each_child_of_node(), and low-level method.
Let's use of_get_child_by_name() instead it

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
 sound/soc/generic/simple-scu-card.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/sound/soc/generic/simple-scu-card.c b/sound/soc/generic/simple-scu-card.c
index ac7ba97..83add14 100644
--- a/sound/soc/generic/simple-scu-card.c
+++ b/sound/soc/generic/simple-scu-card.c
@@ -212,19 +212,14 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
 	bool is_fe;
 
 	/* find 1st codec */
-	i = 0;
-	for_each_child_of_node(node, np) {
-		dai_link = simple_priv_to_link(priv, i);
+	np = of_get_child_by_name(node, PREFIX "codec");
+	if (!np)
+		return -ENODEV;
 
-		if (strcmp(np->name, PREFIX "codec") == 0) {
-			ret = asoc_simple_card_parse_daifmt(dev, node, np,
-							    PREFIX, &daifmt);
-			if (ret < 0)
-				return ret;
-			break;
-		}
-		i++;
-	}
+	ret = asoc_simple_card_parse_daifmt(dev, node, np,
+					    PREFIX, &daifmt);
+	if (ret < 0)
+		return ret;
 
 	i = 0;
 	for_each_child_of_node(node, np) {
-- 
1.9.1



More information about the Alsa-devel mailing list