[alsa-devel] [PATCH 12/15] ALSA: line6: Give up on the lock while URBs are released.

Takashi Iwai tiwai at suse.de
Fri Aug 12 14:04:23 CEST 2016


On Fri, 12 Aug 2016 13:14:35 +0200,
Andrej Kruták wrote:
> 
> On Fri, Aug 12, 2016 at 10:45 AM, Takashi Iwai <tiwai at suse.de> wrote:
> > On Thu, 11 Aug 2016 21:02:24 +0200,
> > Andrej Krutak wrote:
> >>
> >> Done, because line6_stream_stop() locks and calls line6_unlink_audio_urbs(),
> >> which in turn invokes audio_out_callback(), which tries to lock 2nd time.
> >
> > Ditto, write the patch right from the beginning :)
> >
> >
> 
> This actually fixes a lock-bug in the code, so I think I'll send it
> separately (like patch 15). Will think about it...

Ah, right, this is the bug in the upstream code.  Then you should
submit it individually, instead of burying in a patchset.


Takashi


More information about the Alsa-devel mailing list