[alsa-devel] [PATCH v3 4/5] ALSA - hda: Add support for parsing new HDA capabilities

Takashi Iwai tiwai at suse.de
Thu Aug 4 07:46:10 CEST 2016


On Thu, 04 Aug 2016 07:51:34 +0200,
Vinod Koul wrote:
> 
> On Thu, Aug 04, 2016 at 07:30:59AM +0530, Vinod Koul wrote:
> > > > +
> > > > +#ifdef CONFIG_X86
> > > > +	if ((bus->ppcap && boot_cpu_has(X86_FEATURE_ART)))
> > > 
> > > Superfluous parentheses.
> > > Also, don't we need to include asm/cpufeature.h?
> > 
> > Its somehow included, I will check that part as well
> 
> And didnt find how :(
> 
> Btw we include asm/pgtable.h which uses boot_cpu_has() macro.
> So somehow it is getting included.
> 
> Do you want this be explicitly included?

Yes, it's safer.


Takashi


More information about the Alsa-devel mailing list