[alsa-devel] [PATCH 1201/1285] Replace numeric parameter like 0444 with macro

Baole Ni baolex.ni at intel.com
Tue Aug 2 14:26:05 CEST 2016


I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com>
Signed-off-by: Baole Ni <baolex.ni at intel.com>
---
 sound/oss/soundcard.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index b70c7c8..af6d4bf 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -523,8 +523,8 @@ bad:
 static int dmabuf;
 static int dmabug;
 
-module_param(dmabuf, int, 0444);
-module_param(dmabug, int, 0444);
+module_param(dmabuf, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(dmabug, int, S_IRUSR | S_IRGRP | S_IROTH);
 
 /* additional minors for compatibility */
 struct oss_minor_dev {
-- 
2.9.2



More information about the Alsa-devel mailing list