[alsa-devel] How to post cleanup patches ?

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Aug 3 03:12:25 CEST 2016


Hi Mark

Now codec driver and component driver has duplicated callback function,
and snd_soc_register_codec() just copied it to component side.

	int snd_soc_register_codec(xxx) {
		...
 
		if (codec_drv->controls) {
			codec->component.controls = codec_drv->controls;
			codec->component.num_controls = codec_drv->num_controls;
		}
		if (codec_drv->dapm_widgets) {
			codec->component.dapm_widgets = codec_drv->dapm_widgets;
			codec->component.num_dapm_widgets = codec_drv->num_dapm_widgets;
		}
		if (codec_drv->dapm_routes) {
			codec->component.dapm_routes = codec_drv->dapm_routes;
			codec->component.num_dapm_routes = codec_drv->num_dapm_routes;
		}
		...
	}

I think we can cleanup this duplicated function, similar things happen on
.probe, .remove, and platform side too.

I would like to post cleanup patches for these.
As 1st step, remove codec duplicate callback.

But my concern is that you hate big-patch-set, and it is almost 70 patches.
Can I post these patches to ML ? or should I use git pull request ? or I shouldn't post ?

I will post main patches as sample patch

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list