[alsa-devel] [PATCH v3 1/3] conf: topology: Add Skylake i2s conf

[Takashi Iwai]

On Thu, 21 Apr 2016 08:27:36 +0200,
Vinod Koul wrote:
> 
> From: Shreyas NC <shreyas.nc at intel.com>
> 
> The Skylake topology configuration for simple topology graph is
> provided. This exposes the PCM capabilities of the DSP.
> 
> Signed-off-by: Shreyas NC <shreyas.nc at intel.com>
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty at intel.com>
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>
> ---
>  configure.ac                            |   1 +
>  src/conf/topology/Makefile.am           |   2 +-
>  src/conf/topology/sklrt286/Makefile.am  |  11 +
>  src/conf/topology/sklrt286/skl_i2s.conf | 342 ++++++++++++++++++++++++++++++++
>  4 files changed, 355 insertions(+), 1 deletion(-)
>  create mode 100644 src/conf/topology/sklrt286/Makefile.am
>  create mode 100644 src/conf/topology/sklrt286/skl_i2s.conf
> 
> diff --git a/configure.ac b/configure.ac
> index c265ec9e159b..1bf75e6d9c2b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -661,6 +661,7 @@ AC_OUTPUT(Makefile doc/Makefile doc/pictures/Makefile doc/doxygen.cfg \
>  	  src/conf/topology/Makefile \
>  	  src/conf/topology/broadwell/Makefile \
>  	  modules/Makefile modules/mixer/Makefile modules/mixer/simple/Makefile \
> +	  src/conf/topology/sklrt286/Makefile \
>  	  alsalisp/Makefile aserver/Makefile \
>  	  test/Makefile test/lsb/Makefile \
>  	  utils/Makefile utils/alsa-lib.spec utils/alsa.pc)
> diff --git a/src/conf/topology/Makefile.am b/src/conf/topology/Makefile.am
> index f56a96c651e5..cbdb7cf07c97 100644
> --- a/src/conf/topology/Makefile.am
> +++ b/src/conf/topology/Makefile.am
> @@ -1 +1 @@
> -SUBDIRS=broadwell
> +SUBDIRS=broadwell sklrt286
> diff --git a/src/conf/topology/sklrt286/Makefile.am b/src/conf/topology/sklrt286/Makefile.am
> new file mode 100644
> index 000000000000..f10d12fa0f73
> --- /dev/null
> +++ b/src/conf/topology/sklrt286/Makefile.am
> @@ -0,0 +1,11 @@
> +alsaconfigdir = @ALSA_CONFIG_DIR@
> +SUBDIRS = data
> +sklrt286dir = $(alsaconfigdir)/topology/sklrt286
> +sklrt286_DATA = skl_i2s.conf
> +EXTRA_DIST = sklrt286_DATA

Isn't it $(sklrt286_DATA)?

> +install-data-hook:
> +	cp -p media0_in-cpr-0.bin media0_in-mi.bin media0_out-mo.bin media0_out-cpr-6.bin codec0_out-mo.bin codec0_out-cpr-4.bin codec1_out-mo.bin codec1_out-cpr-5.bin codec0_in-cpr-1.bin codec0_in-mi.bin dmic01_hifi_in-cpr-3.bin dmic01_hifi_in-mi.bin hdmi1_pt_out-cpr-7.bin hdmi1_pt_out-cpr-8.bin hdmi2_pt_out-cpr-9.bin hdmi2_pt_out-cpr-10.bin hdmi3_pt_out-cpr-11.bin hdmi3_pt_out-cpr-12.bin $(sklrt286dir)

I guess these bin files aren't present or generated in this patch?
This would break bisection.


thanks,

Takashi