[alsa-devel] [PATCH] aplay: fix lurking capture file overwrite bug

[David Fries]

On Fri, Apr 15, 2016 at 09:25:37PM +0100, Alan Horstmann wrote:
> On Thursday 14 April 2016 05:32, David Fries wrote:
> > If -d was given to arecord while commit
> > 8aa13eec80eac312e4b99423909387660fb99b8f (now reverted) was in effect,
> > the last read would be shorter than the chunk size, but pcm_read would
> > read and return the chunk size, the samples were discarded, and
> > capture() continued in a loop because count never reached 0.  arecord
> > opens a new file each loop iteration, if arecord is dynamically naming
> > files, --use-strftime option or beyond the wave 2GB limit, this will
> > generate a series of header only wave files. 
> 
> <snip>
> 
> > Debian has the effectively broken pcm_read,
> 
> It is fortunate for me that you mentioned those details as I have just been 
> bitten by exactly that, using arecord whilst tracking down a Portaudio issue 
> in Debian Jessie!  I was gearing up to report the bug, assuming it was in the 
> capture system.
> 
> It seems a pity that Debian Jessie stable doesn't have a backport of the 
> fix/revert.

Glad to hear I helped.

I filed a Debian bug report with the two patches that would avoid it as
Bug#821048, but it isn't going to be fixed.  Denial of service is
usually seen as a security issue, and this bug could run the system
out of inodes, I guess it isn't seen as a high enough priority.  I was
able to download and compile 1.1.0-2 on Jessie which doesn't have this
problem.

----------------
Please update to alsa-utils 1.1.0-2 first. In stable there will be
only security patches accepted. Bug closed herewith. Backports are
not maintained from us.

Elimar
----------------

> Now back to tracing the original issue...
> 
> Regards
> 
> Alan
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- 
David Fries <david at fries.net>