[alsa-devel] [PATCH v3 0/7] topology: Add support for vendor tuples

Takashi Iwai tiwai at suse.de
Thu Apr 7 16:58:14 CEST 2016


On Thu, 07 Apr 2016 16:33:13 +0200,
Lin, Mengdong wrote:
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai at suse.de]
> > Sent: Thursday, April 07, 2016 5:22 PM
> > To: mengdong.lin at linux.intel.com
> > Cc: alsa-devel at alsa-project.org; broonie at kernel.org; perex at perex.cz;
> > Girdwood, Liam R; Lin, Mengdong; Koul, Vinod; Prusty, Subhransu S; Ughreja,
> > Rakesh A; Shah, Hardik T
> > Subject: Re: [PATCH v3 0/7] topology: Add support for vendor tuples
> > 
> > On Thu, 07 Apr 2016 09:27:20 +0200,
> > mengdong.lin at linux.intel.com wrote:
> > >
> > > From: Mengdong Lin <mengdong.lin at linux.intel.com>
> > >
> > > This series addes support for vendor tuples to topology, to avoid
> > > importing binary data blob from other files.
> > >
> > > Backward compatibility of ABI is not impacted. A kernel patch is also
> > > submitted "ASoC: topology: ABI - Define types for vendor tuples".
> > >
> > > The 1st patch is small code cleanup.
> > > The 2nd patch is a preparation, since tuples will need the
> > > type-specific free handler.
> > >
> > > History:
> > > v2: add check on string length, use strtol() to get hex value,
> > >     and fix memory leak.
> > > v3: Fix overflow on uuid string copy. Use strtoul() to get unsigned
> > >     vendor values and check range, tested on 32 & 64 bit systems.
> > 
> > The patches look good to me.  The prerequisite is the change in the kernel
> > side.  Mark, how about that?
> > 
> 
> I saw the kernel patch "ASoC: topology: ABI - Define types for vendor tuples" has been merged to ASoC kernel.
> 
> Here is the link:
> http://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=e42839b012eb8179ed2e3571bfcd133fba5df154

OK, assuming that the kernel-side change will be in 4.7, I applied
this patch series now.  Thanks.


Takashi


More information about the Alsa-devel mailing list