[alsa-devel] [PATCH 2/4] ASoC: sti: tdm: uni tdm mode

[Mark Brown]

On Thu, Mar 31, 2016 at 06:00:56PM +0200, Moise Gergaud wrote:
> Implement tdm mode for uni player & reader:
> - Remove "player" in uni type enum => common type enum for player & reader
> - When TDM_ENABLE is set to 1, the i2s format should be automatically
> configured. Unfortunately this is not the case (HW bug). Then, we shall
> force DATA_SIZE setting.
> - Compute the transfer size for tdm mode: transfer size = user frame size
> - Manage tdm slots configuration given in DT.
> - Don't use mclk-fs when unip in tdm mode; use tdm slot config to compute
> frame size and to set mclk rate.
> - Refine the hw param (channels & format) according to tdm slot config.

This looks like a large set of separate changes which should be split
up.  For example, the refactoring to use the same type for plater and
reader seems like it should be separate to the rest of the changes.  As
it is it's a very big change which is hard to review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160402/19dd2b83/attachment.sig>