[alsa-devel] [PATCH 00/15 v3] ALSA: firewire-lib: separate to packet streaming layer and data block processing layer

Takashi Iwai tiwai at suse.de
Tue Sep 29 14:57:15 CEST 2015


On Tue, 29 Sep 2015 14:45:00 +0200,
Takashi Sakamoto wrote:
> 
> On Sep 29 2015 19:55, Takashi Iwai wrote:
> > On Sat, 19 Sep 2015 18:46:53 +0200,
> > Takashi Iwai wrote:
> >>
> >> On Sat, 19 Sep 2015 04:21:47 +0200,
> >> Takashi Sakamoto wrote:
> >>>
> >>> This patchset updates a part of my previous post (patch 01 and 02):
> >>>
> >>> [alsa-devel] [PATCH 00/25 v2] ALSA: support AMDTP variants
> >>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-August/096739.html
> >>>
> >>> The aim of this patchset is to allow current amdtp implementation
> >>> to handle several data block processing backends. For this aim, this
> >>> patchset separates the implementation to packet streaming layer and AM824
> >>> data block processing layer.
> >>>
> >>> The communication between these two layers is done by callback function.
> >>> This patchset adds an overhead to call the functions as the same
> >>> frequently as 8,000 times per second.
> >>
> >> Since I'm traveling now, I can't review in details and will take a
> >> closer look in the next week.  Hopefully other people will give review
> >> comments before that.
> > 
> > There were a few obvious typos (using bit OR instead of logical OR),
> > but otherwise they look good through a quick review, so I merged them
> > with some manual fixes now.  The patches are found in
> > topic/firewire-update branch and merged into for-next branch, too.
> 
> Oops. Patch 15 includes such typos... Thanks for your reviewing and
> fixing ;-)
> 
> I have more patches and I'll post them as a small parts in this
> developing period. I'd be glad if the patches are also reviewd.

Sure, feel free to submit patches at any time.
But I'll be traveling again in the next week for LCE and audio mini
summit, so the review might be taken after that.


thanks,

Takashi


More information about the Alsa-devel mailing list