[alsa-devel] [patch] ALSA: usb-audio: harmless underflow in snd_audigy2nx_led_put()

[Takashi Iwai]

On Mon, 28 Sep 2015 12:06:20 +0200,
Dan Carpenter wrote:
> 
> We want to verify that "value" is either zero or one, so we test if it
> is greater than one.  Unfortunately, this is a signed int so it could
> also be negative.  I think this is harmless but it introduces a static
> checker warning.  Let's make "value" unsigned.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 337c317..4602a78 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -340,7 +340,7 @@ static int snd_audigy2nx_led_put(struct snd_kcontrol *kcontrol,
>  	struct usb_mixer_elem_list *list = snd_kcontrol_chip(kcontrol);
>  	struct usb_mixer_interface *mixer = list->mixer;
>  	int index = kcontrol->private_value & 0xff;
> -	int value = ucontrol->value.integer.value[0];
> +	unsigned int value = ucontrol->value.integer.value[0];
>  	int old_value = kcontrol->private_value >> 8;
>  	int err;
>  
>