[alsa-devel] [PATCH v2 0/9] Add DSP topology management for SKL

Mark Brown broonie at kernel.org
Mon Sep 21 18:33:53 CEST 2015


On Mon, Sep 21, 2015 at 09:27:39AM +0530, Vinod Koul wrote:

> I wouldn't have pinged but had been more than few weeks so was wondering if
> this got missed. I did realise you were travelling and merge window came
> up, but still thought Mark's typical turnaound is 1-2 weeks so was expecting
> something. I do understand this take time but no harm in checking if it is
> beyond usual window one expects.

I'm also not going to merge large patches which have wide impact close
to the merge window and I don't tend to review things without a view to
merging them, especially not things that are more work to review.

> We did decide to use DPCM, DAPM and topology here to solve manging the DSP
> using these frameworks. yes hard coding a simple mixer and two pipes could
> have made code look easy to follow but then we would be redoing those bits
> as we scale these to defferent designs.

Sure, and my point here is that that this process of redoing things
would most likely be a lot faster since it'd be a lot easier to follow
which would make the review a lot easier.

> And to provide what we are trying here I have attached the SKL Topology conf
> file to give a picture of topology we are trying to build as a reference.

I think you missed the attachment here...

> Also where you feel something is missing please do ask. Sometimes things are
> perceived intuitive for us as we are doing this for quire some time but
> may not be so for fresh eyes :)

I have been doing this mostly but it's easy to miss things without the
picture of where we're heading.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150921/dbd32835/attachment-0001.sig>


More information about the Alsa-devel mailing list